ArcPy - Get number of intersected points based on attribute

Question

I am trying to get a number of points in polygons based on row values, and write them into attribute table of polygons. I have polygon (Zones), and points (Objects with fields such as schools, markets, hotels, shops) which are located in those polygons. I want to select points based on their attributes (for example i want to know how many schools are in my polygon, and write it into a field. and repeat that process for other attributes for how many hotels/markets/shops are there in polygon zones, etc).

There was a similar question and this answer was good to Count number of attributes for unique field values, but only for selection by location. That script returned count from all number of objects in polygon zones, and it was not based on attributes, just on location.

I managed to modify the script, from the given link. This is the code, and I get result, sum of all points and it was written into row:

import arcpy
Objects = r'D:\GIS_Temp\Points.shp'
Zones = r'D:\GIS_Temp\Zones.shp'
Objects_lyr = arcpy.MakeFeatureLayer_management(Objects,r'in_memory\Objects_lyr')
Zones_lyr = arcpy.MakeFeatureLayer_management(Zones,r'in_memory\Zones_lyr')
fields = ['Descrip','Point_Sum']
with arcpy.da.UpdateCursor(Zones_lyr,fields) as cur:
    for row in cur:
        Zones = row[0]
        where = '"Descrip" = \'{}\''.format(Zones)
        arcpy.SelectLayerByAttribute_management(Zones_lyr,'NEW_SELECTION',where)
        arcpy.SelectLayerByLocation_management(Objects_lyr,'INTERSECT',Zones_lyr)        
        Point_Sum = int(arcpy.GetCount_management(Objects_lyr).getOutput(0)) 
        row[1] = Point_Sum
        cur.updateRow(row)
print('Operation complete.')

And this is the result:

But I want to update Zones, based on intersecting Objects, but based on attributes, and update rows in Zones, with number of intersecting objects (Hotels, Shops, Markets, Schools).

What am I missing i my code. I suppose it has something to with selection by attributes, or with loop as suggested in comments, I should create loop within a loop, but I am not sure where to put it, and how. I understand why, but do not know how.

EDIT:

I tried to modify code, like this, so I made selection by attribute individually and try to put them in their own row, but with no luck. Code ok, there are not any errors, but it does not update anything.

Is there any modification to this, which would speed up my workflow, in case I have more than four values (like in this example; schools, etc)? This is the code:

import arcpy
Objects = r'D:\GIS_Temp\Points.shp'
Zones = r'D:\GIS_Temp\Zones.shp'
ObjectsSCHOOLS_lyr = arcpy.MakeFeatureLayer_management(Objects,r'SCHOOLS', "\"Name\" = 'Schools'")
ObjectsMARKETS_lyr = arcpy.MakeFeatureLayer_management(Objects,r'MARKETS', "\"Name\" = 'Markets'")
ObjectsHOTELS_lyr = arcpy.MakeFeatureLayer_management(Objects,r'HOTELS', "\"Name\" = 'Hotels'")
ObjectsSHOPS_lyr = arcpy.MakeFeatureLayer_management(Objects,r'SHOPS', "\"Name\" = 'Shops'")
Zones_lyr = arcpy.MakeFeatureLayer_management(Zones,r'in_memory\Zones_lyr')
fields = ['Descrip','Schools_Nr', 'Markets_Nr', 'Hotels_Nr', 'Shops_Nr']
with arcpy.da.UpdateCursor(Zones_lyr,fields) as cur:
    for row in cur:
        state = row[0]
        where = '"Descrip" = \'{}\''.format(Zones)
        arcpy.SelectLayerByAttribute_management(Zones_lyr,'NEW_SELECTION',where)
        arcpy.SelectLayerByLocation_management(ObjectsSCHOOLS_lyr,'INTERSECT',Zones_lyr)        
        Schools_Nr = int(arcpy.GetCount_management(ObjectsSCHOOLS_lyr).getOutput(0)) 
        row[1] = Schools_Nr
        cur.updateRow(row)
    for row in cur:
        state = row[0]
        where = '"Descrip" = \'{}\''.format(Zones)
        arcpy.SelectLayerByAttribute_management(Zones_lyr,'NEW_SELECTION',where)
        arcpy.SelectLayerByLocation_management(ObjectsMARKETS_lyr,'INTERSECT',Zones_lyr)        
        Markets_Nr = int(arcpy.GetCount_management(ObjectsMARKETS_lyr).getOutput(0)) 
        row[1] = Markets_Nr
        cur.updateRow(row)
    for row in cur:
        state = row[0]
        where = '"Descrip" = \'{}\''.format(Zones)
        arcpy.SelectLayerByAttribute_management(Zones_lyr,'NEW_SELECTION',where)
        arcpy.SelectLayerByLocation_management(ObjectsHOTELS_lyr,'INTERSECT',Zones_lyr)        
        Hotels_Nr = int(arcpy.GetCount_management(ObjectsHOTELS_lyr).getOutput(0)) 
        row[1] = Hotels_Nr
        cur.updateRow(row)
    for row in cur:
        state = row[0]
        where = '"Descrip" = \'{}\''.format(Zones)
        arcpy.SelectLayerByAttribute_management(Zones_lyr,'NEW_SELECTION',where)
        arcpy.SelectLayerByLocation_management(ObjectsSHOPS_lyr,'INTERSECT',Zones_lyr)        
        Shops_Nr = int(arcpy.GetCount_management(ObjectsSHOPS_lyr).getOutput(0)) 
        row[1] = Shops_Nr
        cur.updateRow(row)         
print('Operation complete.')

Answer 1

You can refer to the following code, I tested it. Hope it can help you.

import arcpy

arcpy.env.overwriteOutput = True

Objects = r'H:\Input\Points.shp'
Zones = r'H:\Input\Zones.shp'

# Get unique field values (Define a function)
def getUniqueValues(fc,field_name):
    unique_Values = set()
    rows = arcpy.SearchCursor(fc)
    for row in rows:
        unique_Values.add(row.getValue(field_name))
    del row,rows
    return unique_Values

# Get values count by dictionary
def getValuesCount(lyr,fieldName,lst_Values):
    dic_Values_Count = {}
    for value in lst_Values:
        dic_Values_Count[value] = 0
    rows = arcpy.SearchCursor(lyr)
    for row in rows:
        value = row.getValue(fieldName)
        dic_Values_Count[value] += 1
    del row,rows
    return dic_Values_Count

# Get Names list
set_obj_Names = getUniqueValues(Objects,'Name')
# Get Unique Zone_Name
set_zone_Names = getUniqueValues(Zones,'Zone_Name') # If you want to use Descrip, you can replace 'Zone_Name to 'Descrip'

# Delete exists names
obj_Names = list(set_obj_Names)
obj_Names.append('Point_Sum')
arcpy.DeleteField_management(Zones,obj_Names)

# Add need fields
for field_Name in obj_Names:
    field_Type = "TEXT"
    if field_Name == 'Point_Name':
        field_Type = 'SHORT'
    arcpy.AddField_management(Zones,field_Name,field_Type)

# Main

Objects_lyr = arcpy.MakeFeatureLayer_management(Objects,r'Objects_lyr')
Zones_lyr = arcpy.MakeFeatureLayer_management(Zones,r'Zones_lyr')
# Get Count and save it into temp dictionary
whereField = arcpy.AddFieldDelimiters(Zones,'Zone_Name')
dic_ZoneInfo = {}
for zone_Name in set_zone_Names:
    whereClause = whereField + " = '" + zone_Name + "'"
    arcpy.SelectLayerByAttribute_management(Zones_lyr,'NEW_SELECTION',whereClause)
    arcpy.SelectLayerByLocation_management(Objects_lyr,'INTERSECT',Zones_lyr)
    Point_Sum  =  int(arcpy.GetCount_management(Objects_lyr).getOutput(0))
    dicTemp = getValuesCount(Objects_lyr,'Name',obj_Names)
    dicTemp['Point_Sum'] = Point_Sum
    dic_ZoneInfo[zone_Name] = dicTemp
del Objects_lyr,Zones_lyr

# Update Counts and Point_Sum
updateRows = arcpy.UpdateCursor(Zones)
for row in updateRows:
    zone_Name = row.getValue('Zone_Name')
    dic_Values_Count = dic_ZoneInfo[zone_Name]
    new_Fields = obj_Names
    new_Fields.append('Point_Sum')
    for field_Name in new_Fields:
        row.setValue(field_Name,dic_Values_Count[field_Name])
    updateRows.updateRow(row)
del row,updateRows

Answer 2

As I had few errors with the code, I removed the

del row, rows

from line 20, which is the part of the code for getting values count. Now it appears to be working. If i do not delete this part, I get this error:

Runtime error Traceback (most recent call last): File "", line 41, in File "", line 20, in getValuesCount UnboundLocalError: local variable 'row' referenced before assignment

But, everything else from accepted answer is working. Maybe this is something in my code, but this is working, at least for me:

import arcpy
arcpy.env.overwriteOutput = True
Objects = r'D:\GIS_Temp\Points.shp'
Zones = r'D:\GIS_Temp\Zones.shp'
def getUniqueValues(fc,field_name):
    unique_Values = set()
    rows = arcpy.SearchCursor(fc)
    for row in rows:
        unique_Values.add(row.getValue(field_name))
    del row,rows
    return unique_Values
def getValuesCount(lyr,fieldName,lst_Values):
    dic_Values_Count = {}
    for value in lst_Values:
        dic_Values_Count[value] = 0
    rows = arcpy.SearchCursor(lyr)
    for row in rows:
        value = row.getValue(fieldName)
        dic_Values_Count[value] += 1
    # here was delete row rows part, and it was deleted and now it works
    return dic_Values_Count
set_obj_Names = getUniqueValues(Objects,'Name')
set_zone_Names = getUniqueValues(Zones,'Zone_Name')
obj_Names = list(set_obj_Names)
obj_Names.append('Point_Sum')
arcpy.DeleteField_management(Zones,obj_Names)
for field_Name in obj_Names:
    field_Type = "TEXT"
    if field_Name == 'Point_Name':
        field_Type = 'SHORT'
    arcpy.AddField_management(Zones,field_Name,field_Type)
Objects_lyr = arcpy.MakeFeatureLayer_management(Objects,r'Objects_lyr')
Zones_lyr = arcpy.MakeFeatureLayer_management(Zones,r'Zones_lyr')
whereField = arcpy.AddFieldDelimiters(Zones,'Zone_Name')
dic_ZoneInfo = {}
for zone_Name in set_zone_Names:
    whereClause = whereField + " = '" + zone_Name + "'"
    arcpy.SelectLayerByAttribute_management(Zones_lyr,'NEW_SELECTION',whereClause)
    arcpy.SelectLayerByLocation_management(Objects_lyr,'INTERSECT',Zones_lyr)
    Point_Sum  =  int(arcpy.GetCount_management(Objects_lyr).getOutput(0))
    dicTemp = getValuesCount(Objects_lyr,'Name',obj_Names)
    dicTemp['Point_Sum'] = Point_Sum
    dic_ZoneInfo[zone_Name] = dicTemp
del Objects_lyr,Zones_lyr
updateRows = arcpy.UpdateCursor(Zones)
for row in updateRows:
    zone_Name = row.getValue('Zone_Name')
    dic_Values_Count = dic_ZoneInfo[zone_Name]
    new_Fields = obj_Names
    new_Fields.append('Point_Sum')
    for field_Name in new_Fields:
        row.setValue(field_Name,dic_Values_Count[field_Name])
    updateRows.updateRow(row)
del row,updateRows