Questions tagged [code-review]
Questions requesting a review of working code should be asked at the Code Review Stack Exchange
48
questions
2
votes
1answer
39 views
Creating NDVI from raster using ArcPy
I have to create NDVI's for multiple raster images, and so want to find out the most efficient way to do it.
The code below works, but I wondered if there was a more efficient way to do it?
# ...
0
votes
0answers
27 views
Shortening use of If statements with ArcPy [closed]
New python user here I was wanting to know if what a better way to condense this update cursor script that I'm trying to write.
database = 'C:\M2_Q3.gdb\data'
attributes = ['S_0__FT_', 'S_1__FT_', '...
4
votes
1answer
82 views
Optimizing Intersection Area Loops on big layers using PyQGIS
Using 3.10.1-A Coruña on Windows 10
I am looping over some (10) national shapefiles and finding intersection and areas but the process is very slow.
I have two loops - one loop for each postcode and ...
1
vote
0answers
49 views
Tool Script for Geojson to Shapefile
I am creating an Arcmap tool script that takes user input and then takes a geojson file from a specified folder and then opens it into Arcmap as a shapefile. The issue I am running into is that I am ...
1
vote
0answers
35 views
Alternative to Rasterio Mask module for clipping a raster using masked geojson
I am clipping a raster (.tif file) using a mask vector (.geojson) file.
with rasterio.open(url) as src:
out_image, out_transform = rasterio.mask.mask(src, shapes, crop=True)
But, this ...
1
vote
1answer
45 views
Improving ArcPy script for ArcMap to only return rows of selected polygons instead of all polygons in layer
I am debugging a code provided to me that merges two polygons and alters the fields of "FID1' and "CALC_AREA."
I have realized that the current code searches every layer in the map document for ...
0
votes
1answer
38 views
Creating dictionary of link and its adjacent links (having common vertex) in ArcPy
How do I create a dictionary that has the linkID of a link as key and linkID of touching links as values?
I have used this code in ArcPy but it takes a very long time.
arcpy.CopyFeatures_management(...
0
votes
1answer
67 views
Google Earth Engine : error: Cannot use 'in' operator to search for 'type' in {“type”:“LinearRing”,“coordinates”:
I'm trying to export Sentinel-1 bands with this code in Google Earth Engine but I have recently this error:
Cannot use 'in' operator to search for
'type' in {"type":"LinearRing","coordinates":
I ...
1
vote
0answers
29 views
Optimizing Google Earth Engine cloud cover for Sentinel 5p
I am trying to generate cloud free Sentinel 5p images, I have a basic cloud detection code working but it runs very slowly (most likely due to nested map and reduce features).
Is there a way to do ...
1
vote
0answers
36 views
QGIS 3.8 Python Code for calculate area
Is this the the best solution to calculate the area of the features?
parent = iface.mainWindow()
mc = iface.mapCanvas()
fldname = "m2" #field which has the values for squaremeters
myLyr = mc....
0
votes
0answers
24 views
Getting Exported bands must have compatible data types; found inconsistent types: Float64 and Float32 using Google Earth Engine [duplicate]
I'm trying to export sentinel-1 bands with this code in Google Earth Engine but I have recently this error. I didn't have this problem in the past. So here is the code.
The code:
var start = new ...
2
votes
1answer
75 views
Optimising Large Spatial Queries in SQL
I'm sure similar answers have been given elsewhere but no matter what I have tried I am unable to optimise this query.
Details: TableA has 3.5mill records TableB Had 57000 records but I have ...
0
votes
1answer
53 views
Getting same result with less code with PythonWin ArcPy? [closed]
I have finished writing code and it does what I need without having any error. However, I am wondering if there is any option to get the same result in fewer lines, pecially the for loop inside the ...
0
votes
1answer
37 views
Automate Selection/Copy Features from Selection
I am new to Python and ArcPy, but I would like to automate this process and/or make my code more efficient here. I am basically selecting a layer by attribute, then copying features from the (selected)...
1
vote
1answer
46 views
Speeding up script to flag nodes within 100 feet of segments using PostGIS?
I'm working with two datasets, attempting to flag when an intersection is within 100 feet of a network subset. There are over 40,000 intersections and my network is ~ 1400 segments.
The problem with ...
2
votes
1answer
85 views
Populating layer field with dict.values() in PyQGIS 3?
I've coded the script below in PyQGIS 3 to get the azimuth of starting or ending points for a line layer that touches a border. It works fine, but I want to populate the azimuth field layer with the ...
1
vote
0answers
81 views
Calculating nearest distance between points and Spatial Polygons in R? [closed]
So right now I have pretty large datasets, about 200,000 (lat,long) locations and a Large SpatialPolygonsDataFrame with a polygons list of length 428386 spread in a single city of around 450 square ...
-1
votes
1answer
66 views
Making looping through line segments for vertex points faster?
I am trying to speed up some current code that I have for looping through lines, getting their segments and ultimately the vertex points in Python.
Can anyone recommend a faster method than what I ...
3
votes
1answer
560 views
Counting points in polygons with sf package of R? [closed]
I'm quite new to R and especially GIS with R. So recently I had to proceed to a quite simple analysis: counting health centers (points) per administrative unit (polygons). Quite common process in ...
0
votes
0answers
106 views
Why is internal memory not overwritten?
I have the following code in Python for ArcMap to first select a property polygon and then with this selection to intersect the layer which contains lines (sewers) (which pass through or are within ...
1
vote
0answers
52 views
Making ArcPy script quicker? [closed]
The script below is used to update a shp which is missing values from another .shp using a spatial reference. It's taking about 19 minutes to run through ~53,000 rows. Any ideas on how I can make it ...
1
vote
1answer
374 views
I can not export the image to the drive in Google Earth Engine (GEE)
Whenever I try to export to the drive the image gives me the following error:
Error: Invalid argument: 'image' must be of type Image.
This is my code:
var mod11 = ee.ImageCollection("MODIS/MOD11A2"...
1
vote
1answer
89 views
Using accumulate function for temperature units?
I am working on a piece of code that is designed to aggregate growing degree days for a particular region.
To start, the equation for growing degree days is: Daily GDD (°F) = Daily Average ...
3
votes
2answers
91 views
ArcPy UpdateCursor deleting duplicate records?
I am working with .dbf files. I have two columns of data that have duplicates. A column of parcel numbers with duplicates and a column of letters that are duplicated. I want to delete all parcel ...
0
votes
0answers
241 views
Leaflet Mobile Performance (A Couple of Polygons)
I wrote a small Angular app with leaflet.js. In desktop browser scrolling and dragging speed is good but on mobile browser, performance is painfully.
There are 8 polygon and 129 circle marker on the ...
1
vote
1answer
152 views
Reducing hourly rainfall data to monthly data for particular period of time and making a timeseries chart
I am working with GSMaP image collection (hourly rainfall data) in Google Earth Engine. I would like to make a script which is calculating and making a chart of sum rainfall in particular location ...
2
votes
4answers
84 views
More Efficient Conditional Statements - ArcGIS Field Calculator
I am new to Python and have successfully created the following statement that writes a change period value (01 or 02) based on the municipality and date fields. I am wondering if anyone could point ...
2
votes
0answers
299 views
Moving Feature Class to Different Feature Dataset within Same File Geodatabase using ArcPy?
I want to progammatically move a feature class into a different feature dataset within the same file geodatabase. I'm wondering if there is a way of doing this without including code to rename and ...
-1
votes
1answer
53 views
More Pythonic way to loop through UpdateCursor?
I have several sets of fields to populate based on other fields. The code below works, but I am wondering if there is a more Pythonic way to march through the i,j pairs? (Actual fieldnames are not ...
0
votes
2answers
35 views
Changing values in column based on another column in arcpy
I created new field in a table named 'Cimp'. Now I want to put there values that depends on values from column "COS_Cod" for example, if COS_Cod starts with 1.1 then Cimp is equal to 1. COS_Cod is a ...
0
votes
1answer
570 views
Fastest way to know in which section of line is a point
I have a line and a point. I want to locate where is this point in the line according to imaginary sections I make (any way I want). The output should be in which number of section is the point (...
1
vote
1answer
2k views
Fastest way to extract a raster in R (improve the time of my reproducible code)
I'm wondering if I have maximized the speed at which a mean of an area buffered around a point in a raster can be extracted.
Fastest way I have ever found to extract a raster, with the pre-cropping ...
1
vote
0answers
57 views
Unable to get points in buffer on selected feature in QGIS using Python?
I have to create a 1.5 km buffer on each latitude/longitude of layer A. I would like to know how many points of line B will be inside the buffer of layer A. I used the following code but it takes too ...
0
votes
0answers
558 views
Speeding-up processing of pair-wise distance calculation in Python?
I am trying to do a cluster analysis using DBSCAN for my time series NDVI image in Python. I am using distance time warping (DTW) to measure distances between my time series. With this, I am computing ...
1
vote
1answer
62 views
Counting only data points which are within a specified radius of other data points?
I wanted to know if I am on the right track here with what I am trying to do. I have two shapefiles, the first contains point data for all the businesses in DC and the other contains point data all ...
0
votes
1answer
211 views
Overview of available images per image collection?
I´m trying to make an overview in a table or graph of the available images in Landsat, Sentinel and Modis series for a certain area of interest. Although I could solve it as follows, this is obviously ...
1
vote
0answers
269 views
Finding a more efficient way to execute a long-run python script [closed]
I'm executing a python script which does these steps:
iterates through 19 features (makes pairs "each one with each other", order doesn't matter: A-B = B-A)
Creates Closest Facility Layer
Adds ...
1
vote
1answer
257 views
Improving poor performance of ArcPy update cursor with ArcSDE and Editor? [closed]
I am using ArcGIS 10.5 in an ArcSDE environment.
I have two tables, they are the exact same table schemas, but one is being edited and those edits are being pushed to the main table. I am a little ...
1
vote
0answers
41 views
Improve my arcpy script for simple querying [closed]
I am quite new to coding python in arcmap so I would like to get my code reviewed and hopefully improved.
I have two Shapefiles, one contain polygons of cities borders and the other is points ...
-1
votes
1answer
261 views
Exporting attributes table from csv to spatialite file using PyQGIS?
I have this python script which allows me to convert delimited text file to spatialite . I used a loop to export attributes table to the output file and it takes over 2 hours when I execute the code ...
1
vote
2answers
268 views
Simpler Method to Map Fields in Spatial Join
I've cobbled together a script, part of which creates field mapping to sum fields in a spatial join. It took 13 lines of codes just to define which fields I want summed in the output. Is there a ...
0
votes
1answer
306 views
Route Layer with ArcPy and OSM Data - very slow
This is my first attempt at using arcpy: I have two CSVs which have columns:
CSV1: join|id_a|lat_a|lon_a
CSV2: join|id_b|lat_b|lon_b
Each has got 100 rows of data. I would like to write a script ...
2
votes
0answers
154 views
How to speed up my script? [closed]
I am looking for the way to speed up my script. It is working fine, I mean, the final output is as required, but it is clunky and really slow. It is slow because of the double 'for..in..' loops, I ...
0
votes
1answer
1k views
Arcpy - Out of memory [closed]
I'm new at making scripts and I´m having some issues in my first arcpy script.
I've created a code that automates maps creation, and it's running ok but gradually increases the memory consumption ...
7
votes
2answers
6k views
Maximizing Code Performance for Shapely
I've written this code in order to calculate the percent cover of grassland within a national park, within 20km^2 of points of recorded occurrences for a species. It is designed to only consider the ...
6
votes
4answers
2k views
Optimising and speeding up ArcPy code? [closed]
Again my lines of surface runoff. I made a script, solving the issue when lines cross other lines. Something like generalization. Like on the picture below. The problem is that I have to solve 30 ...
1
vote
1answer
302 views
Improve Python script logic/structure for erasing features with arcpy
How can I define (and therefore, research/learn how to use) the Pythonic concept for writing a script that can take one input variable, compare it against a list of other variables, and then holding ...
29
votes
2answers
6k views
Using OGR and Shapely more efficiently? [closed]
I'm looking for some suggestions about how to make my python code more efficient. Normally efficiency doesn't matter for me but I am now working with a text file of US locations with over 1.5 million ...
